♻️🎨 [Frontend] Study Store II #8090
Merged
+204
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into enh/study-store
…into enh/study-store
…into enh/study-store
odeimaiz
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors study-related API interactions to use centralized store singletons (osparc.store.Study and osparc.store.Templates), reducing duplicated fetch calls and consolidating state and debt management.
- Introduces
osparc.store.Studywith methods for opening, closing, creating, duplicating, and paying debt for studies, plus events and caching for study state/debt. - Adds
osparc.store.Templates.createTemplateand updates the Resources specification forpostToTemplate. - Replaces direct
osparc.data.Resources.fetchcalls across multiple components and updates corresponding tests and handlers.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/viewer/NodeViewer.js | Switched study open to use osparc.store.Study.openStudy |
| services/static-webserver/client/source/class/osparc/study/Utils.js | Updated createStudyAndPoll to call osparc.store.Study methods |
| services/static-webserver/client/source/class/osparc/study/CreateFunction.js | Replaced template fetch with osparc.store.Templates.createTemplate |
| services/static-webserver/client/source/class/osparc/study/BillingSettings.js | Changed debt payment to use osparc.store.Study.payDebt |
| services/static-webserver/client/source/class/osparc/store/Templates.js | Added createTemplate helper |
| services/static-webserver/client/source/class/osparc/store/Study.js | New singleton with state/debt management and API wrappers |
| services/static-webserver/client/source/class/osparc/store/Store.js | Removed duplicated state/debt logic |
| services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js | Updated close and state polling to use store methods |
| services/static-webserver/client/source/class/osparc/desktop/MainPage.js | Updated template creation and study state polling via stores |
| services/static-webserver/client/source/class/osparc/data/model/Study.js | Modified model’s openStudy to delegate to store.Study |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Moved postToTemplate endpoint under correct section |
| services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js | Switched listeners and invalidation to store.Study |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Updated debt lookup to store.Study.getStudyDebt |
Comments suppressed due to low confidence (5)
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js:631
- The call to
osparc.store.Studyis incorrect. You should useosparc.store.Study.getInstance().getStudyState(pipelineId)without invokingStudyas a function.
osparc.store.Study().getInstance().getStudyState(pipelineId);
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js:931
closeStudywas moved toosparc.store.Study. Update this call toosparc.store.Study.getInstance().closeStudy(this.getStudy().getUuid()).
osparc.store.Store.getInstance().closeStudy(this.getStudy().getUuid())
services/static-webserver/client/source/class/osparc/desktop/MainPage.js:312
- Incorrect invocation of the Study store. Use
osparc.store.Study.getInstance().getStudyState(studyId)instead of callingStudy().
osparc.store.Study().getInstance().getStudyState(studyId);
services/static-webserver/client/source/class/osparc/desktop/MainPage.js:358
- Incorrect invocation of the Study store. Replace with
osparc.store.Study.getInstance().getStudyState(studyId).
osparc.store.Study().getInstance().getStudyState(studyId);
services/static-webserver/client/source/class/osparc/study/BillingSettings.js:241
- The variable
walletIdis not defined here. You should extract it from thewalletobject returned by__getSelectedWallet(), e.g.,wallet.getWalletId().
osparc.store.Study.getInstance().payDebt(this.__studyData["uuid"], walletId, this.__studyData["debt"])
matusdrobuliak66
approved these changes
Jul 11, 2025
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Continuation of #8087
Related issue/s
How to test
Dev-ops